jenkins-bot has submitted this change and it was merged.
Change subject: Cast UploadWizardErrorFlowEvent.message to string
......................................................................
Cast UploadWizardErrorFlowEvent.message to string
Sometimes this parameter is a function, which causes the
EventLogging type check to error out. This way the message
will become '[object Function]' which is not helpful but at
least does not break the logging.
Change-Id: I093769d34d82c52dfc31804b03998b240e1d3619
---
M resources/uw.EventFlowLogger.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gilles: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/uw.EventFlowLogger.js b/resources/uw.EventFlowLogger.js
index 1401ff1..18e5d4b 100644
--- a/resources/uw.EventFlowLogger.js
+++ b/resources/uw.EventFlowLogger.js
@@ -104,7 +104,7 @@
this.log( 'UploadWizardErrorFlowEvent', {
step: step,
code: data.code,
- message: data.message
+ message: String(data.message) // could be a function
which kills EventLogging
} );
};
--
To view, visit https://gerrit.wikimedia.org/r/169919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I093769d34d82c52dfc31804b03998b240e1d3619
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
