Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170694
Change subject: Use Title::quickUserCan in EntityPermissionChecker
......................................................................
Use Title::quickUserCan in EntityPermissionChecker
Change-Id: If3b94a329ed51c2881f383356d5f7d58bfa7da32
---
M repo/includes/content/EntityContentFactory.php
1 file changed, 1 insertion(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/94/170694/1
diff --git a/repo/includes/content/EntityContentFactory.php
b/repo/includes/content/EntityContentFactory.php
index d96bf3b..da286ed 100644
--- a/repo/includes/content/EntityContentFactory.php
+++ b/repo/includes/content/EntityContentFactory.php
@@ -332,14 +332,7 @@
public function getEditPermissionForTitle( Title $title, EntityContent
$content, User $user ) {
$entityContentTitle = $this->getTitleForId(
$content->getEntity()->getId() );
- if ( $entityContentTitle->getFullText() !==
$title->getFullText() ) {
- throw new MWException( '$title does not match content'
);
- }
-
- $errors = $title->getUserPermissionsErrors( 'edit', $user,
'quick' );
- $permissionStatus = $this->getStatusForPermissionErrors(
$errors );
-
- return $permissionStatus->isOK();
+ return $entityContentTitle->quickUserCan( 'edit', $user );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/170694
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3b94a329ed51c2881f383356d5f7d58bfa7da32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
