Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170697
Change subject: Catch backwards selection error in Firefox
......................................................................
Catch backwards selection error in Firefox
Bug: 72835
Change-Id: I6dce13c91436139894656a8bfcfb8fe0a6f96d20
---
M src/ce/ve.ce.Surface.js
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/97/170697/1
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 50c81d0..aa95613 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -2905,7 +2905,13 @@
endRange = nativeRange.cloneRange();
endRange.collapse( false );
this.nativeSelection.addRange( endRange );
- this.nativeSelection.extend(
nativeRange.startContainer, nativeRange.startOffset );
+ try {
+ this.nativeSelection.extend(
nativeRange.startContainer, nativeRange.startOffset );
+ } catch ( e ) {
+ // Firefox sometimes fails when nodes are
different,
+ // see
https://bugzilla.mozilla.org/show_bug.cgi?id=921444
+ this.nativeSelection.addRange( nativeRange );
+ }
} else {
this.nativeSelection.addRange( nativeRange );
}
--
To view, visit https://gerrit.wikimedia.org/r/170697
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6dce13c91436139894656a8bfcfb8fe0a6f96d20
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
