jenkins-bot has submitted this change and it was merged.
Change subject: WikiGrok B: Advance without selecting a tag
......................................................................
WikiGrok B: Advance without selecting a tag
Bug: 72795
Change-Id: I29ab3e0b8981b763920534ce57d4ef792289b5eb
---
M javascripts/modules/wikigrok/WikiGrokDialogB.js
M templates/modules/wikigrok/WikiGrokDialogB.hogan
2 files changed, 2 insertions(+), 6 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/wikigrok/WikiGrokDialogB.js
b/javascripts/modules/wikigrok/WikiGrokDialogB.js
index 56cd87a..0f2ab31 100644
--- a/javascripts/modules/wikigrok/WikiGrokDialogB.js
+++ b/javascripts/modules/wikigrok/WikiGrokDialogB.js
@@ -75,10 +75,6 @@
$tag = $( '<div
class="ui-tag-button mw-ui-button">' ).
on( 'click', function
() {
$( this
).toggleClass( 'mw-ui-progressive' );
- // Update save
button
- setTimeout(
function () {
-
self.$save.prop( 'disabled', self.$( '.wg-buttons .mw-ui-progressive' ).length
=== 0 );
- }, 100 );
} ).appendTo( self.$(
'.wg-buttons' ) );
// FIXME: Use a template for
this magic.
@@ -138,8 +134,8 @@
self.$( '.wg-buttons, .footer' ).hide();
self.$( '.wg-content' ).text( 'You just
made Wikipedia a little better, thanks!' );
self.$( '.wg-link' ).show();
- self.log( 'widget-click-submit' );
} );
+ self.log( 'widget-click-submit' );
} );
// hide this Dialog when the user reads more about
Wikigrok
diff --git a/templates/modules/wikigrok/WikiGrokDialogB.hogan
b/templates/modules/wikigrok/WikiGrokDialogB.hogan
index 2925af4..1a201f4 100644
--- a/templates/modules/wikigrok/WikiGrokDialogB.hogan
+++ b/templates/modules/wikigrok/WikiGrokDialogB.hogan
@@ -16,7 +16,7 @@
<div class="footer">
<span class="license">All submissions are <a
href="#/wikigrok/about">released freely</a>.</span>
- <button class="mw-ui-button mw-ui-constructive save"
disabled>Next</button>
+ <button class="mw-ui-button mw-ui-constructive
save">Next</button>
<div class="spinner loading"></div>
</div>
</div>
--
To view, visit https://gerrit.wikimedia.org/r/170374
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29ab3e0b8981b763920534ce57d4ef792289b5eb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
