jenkins-bot has submitted this change and it was merged.

Change subject: Remove Handlebars Mantle dependency
......................................................................


Remove Handlebars Mantle dependency

Dependency: Ic59f01673c74def073e328fd5fd46d8d5c6348ed
Change-Id: I4e3f23b8263218d8dd68be4aeed049553ffe3d5b
---
M includes/Resources.php
M javascripts/common/templates/handlebars.js
2 files changed, 2 insertions(+), 5 deletions(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Resources.php b/includes/Resources.php
index 02af7ed..c1c14fb 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -58,7 +58,6 @@
        ),
        'ext.mantle.handlebars' => $wgMantleResourceBoilerplate + array(
                'dependencies' => array(
-                       'ext.mantle.templates',
                        'mediawiki.template',
                ),
                'scripts' => array(
diff --git a/javascripts/common/templates/handlebars.js 
b/javascripts/common/templates/handlebars.js
index 185ca25..95cd113 100644
--- a/javascripts/common/templates/handlebars.js
+++ b/javascripts/common/templates/handlebars.js
@@ -1,5 +1,5 @@
 // Register the Handlebars compiler with MediaWiki.
-( function( M ) {
+( function() {
        /*
         * @class HandlebarsTemplateCompiler
         * @singleton
@@ -22,7 +22,5 @@
 
        // register Handlebars with core.
        mw.template.registerCompiler( 'handlebars', handlebars );
-       // @deprecate
-       M.template.registerCompiler( 'handlebars', handlebars );
 
-}( mw.mantle ) );
+}() );

-- 
To view, visit https://gerrit.wikimedia.org/r/170099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e3f23b8263218d8dd68be4aeed049553ffe3d5b
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/Mantle
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to