Brion VIBBER has submitted this change and it was merged.
Change subject: Migrate all app install IDs to be the same as the old reading
action ID.
......................................................................
Migrate all app install IDs to be the same as the old reading action ID.
As per the meeting between Product and Analytics, we're migrating all app
install IDs in all app schemas to be the same, so that the tables can be
joined and the overlap in users between features can be found.
This patch changes all app install IDs so that they're the same as the install
ID that was previously used for reading actions. That way, the analysis that's
generated on an ongoing basis by analytics will remain unchanged, whereas the
EventLogging data install IDs will all change, but simply go in to new tables.
Change-Id: I82bdfaa8446e47d1ded37b18119f818a26249a68
---
M wikipedia/EventLogging/SavedPagesFunnel.m
M wikipedia/EventLogging/ToCInteractionFunnel.h
M wikipedia/EventLogging/ToCInteractionFunnel.m
3 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Brion VIBBER: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikipedia/EventLogging/SavedPagesFunnel.m
b/wikipedia/EventLogging/SavedPagesFunnel.m
index a83cf48..1e5b9af 100644
--- a/wikipedia/EventLogging/SavedPagesFunnel.m
+++ b/wikipedia/EventLogging/SavedPagesFunnel.m
@@ -13,9 +13,9 @@
-(id)init
{
// http://meta.wikimedia.org/wiki/Schema:MobileWikiAppSavedPages
- self = [super initWithSchema:@"MobileWikiAppSavedPages" version:8909354];
+ self = [super initWithSchema:@"MobileWikiAppSavedPages" version:10375480];
if (self) {
- self.appInstallID = [self persistentUUID:@"SavedPages"];
+ self.appInstallID = [self persistentUUID:@"ReadingAction"];
}
return self;
}
diff --git a/wikipedia/EventLogging/ToCInteractionFunnel.h
b/wikipedia/EventLogging/ToCInteractionFunnel.h
index abda3c0..a9fe67e 100644
--- a/wikipedia/EventLogging/ToCInteractionFunnel.h
+++ b/wikipedia/EventLogging/ToCInteractionFunnel.h
@@ -10,7 +10,7 @@
@interface ToCInteractionFunnel : EventLoggingFunnel
-@property NSString *tocInteractionToken;
+@property NSString *appInstallID;
-(id)init;
-(NSDictionary *)preprocessData:(NSDictionary *)eventData;
diff --git a/wikipedia/EventLogging/ToCInteractionFunnel.m
b/wikipedia/EventLogging/ToCInteractionFunnel.m
index d89bcd3..7a5c72e 100644
--- a/wikipedia/EventLogging/ToCInteractionFunnel.m
+++ b/wikipedia/EventLogging/ToCInteractionFunnel.m
@@ -14,9 +14,9 @@
{
// https://meta.wikimedia.org/wiki/Schema:MobileWikiAppToCInteraction
self = [super initWithSchema:@"MobileWikiAppToCInteraction"
- version:8461467];
+ version:10375484];
if (self) {
- self.tocInteractionToken = [self persistentUUID:@"ToCInteraction"];
+ self.appInstallID = [self persistentUUID:@"ReadingAction"];
}
return self;
}
@@ -24,7 +24,7 @@
-(NSDictionary *)preprocessData:(NSDictionary *)eventData
{
NSMutableDictionary *dict = [eventData mutableCopy];
- dict[@"tocInteractionToken"] = self.tocInteractionToken;
+ dict[@"appInstallID"] = self.appInstallID;
return [NSDictionary dictionaryWithDictionary: dict];
}
--
To view, visit https://gerrit.wikimedia.org/r/170286
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82bdfaa8446e47d1ded37b18119f818a26249a68
Gerrit-PatchSet: 2
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <dga...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
