Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170994
Change subject: hygiene: Change source to task_type for consistency
......................................................................
hygiene: Change source to task_type for consistency
Dependent on WikiGrok change I1a5a44606ffd4b3bf83d294a2299e42d09462163
Change-Id: I582365cae34014d67d76593b039b755c3b530dac
---
M javascripts/modules/wikigrok/WikiGrokResponseApi.js
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/94/170994/1
diff --git a/javascripts/modules/wikigrok/WikiGrokResponseApi.js
b/javascripts/modules/wikigrok/WikiGrokResponseApi.js
index 77af849..845f136 100644
--- a/javascripts/modules/wikigrok/WikiGrokResponseApi.js
+++ b/javascripts/modules/wikigrok/WikiGrokResponseApi.js
@@ -11,8 +11,8 @@
this.subjectId = options.itemId;
this.subject = options.subject;
this.userToken = options.userToken;
- this.taskType = 'mobile ' + options.version;
this.taskToken = options.taskToken;
+ this.taskType = 'mobile ' + options.version;
this.testing = false; // FIXME: TBD on what qualifies
as a test
Api.prototype.initialize.apply( this, arguments );
},
@@ -28,11 +28,9 @@
page_id: mw.config.get( 'wgArticleId' ),
user_token: this.userToken,
task_token: this.taskToken,
+ task_type: this.taskType,
subject_id: this.subjectId,
subject: this.subject,
- // TODO: Change 'source' to 'taskType' for
consistency
- // Change needs to be also made in
WikiGrok::ApiResponse
- source: this.taskType,
mobile_mode: M.getMode(),
testing: this.testing,
claims: JSON.stringify( claims )
--
To view, visit https://gerrit.wikimedia.org/r/170994
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I582365cae34014d67d76593b039b755c3b530dac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Robmoen <rm...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
