Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/171165
Change subject: Fix indicator alignment in MWCategoryItemWidget
......................................................................
Fix indicator alignment in MWCategoryItemWidget
We were setting the height to 2.25em which just happened
to be right, but it depended on the browser's default
line-height being a certain value. Now that that's changed
with unisolation, the alignment breaks.
Instead of using a magic value, use height: 100%; so it
takes the parent's height. We don't even have to make the
parent position: relative; because it already is.
Also change the width to 2em, which is a much more defensible
value than 2.25em. Previously 2.25em kind of made sense because
that was also the height (resulting in a square box), but
now we don't have that excuse any more.
Bug: 72962
Change-Id: Id617bfaafefd1fc1530fbee29be5d935ec486b92
---
M modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/65/171165/1
diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
index 2b43810..2dc0e57 100644
--- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
@@ -65,8 +65,8 @@
position: absolute;
right: 0;
top: 0;
- width: 2.25em;
- height: 2.25em;
+ width: 2em;
+ height: 100%;
background-repeat: no-repeat;
background-position: center center;
-}
\ No newline at end of file
+}
--
To view, visit https://gerrit.wikimedia.org/r/171165
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id617bfaafefd1fc1530fbee29be5d935ec486b92
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
