Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/171732
Change subject: Hygiene: Goodbye mobile.stable.common ...................................................................... Hygiene: Goodbye mobile.stable.common Change-Id: I9f3ffdb8ac5c5eba375a880031e11d545097adf1 --- M includes/Resources.php 1 file changed, 8 insertions(+), 26 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/32/171732/1 diff --git a/includes/Resources.php b/includes/Resources.php index 5279abe..41d80d5 100644 --- a/includes/Resources.php +++ b/includes/Resources.php @@ -203,8 +203,8 @@ 'mobile.editor' => $wgMFResourceFileModuleBoilerplate + array( 'dependencies' => array( - 'mobile.stable.common', - 'mobile.overlays', + 'mobile.startup', + 'mobile.drawers', 'mediawiki.ui.input', ), 'messages' => array( @@ -317,7 +317,7 @@ 'mobile.stable', 'mobile.templates', 'mobile.editor.common', - 'mobile.stable.common', + 'mobile.overlays', ), 'styles' => array( 'less/modules/editor/VisualEditorOverlay.less', @@ -662,24 +662,6 @@ ), ), - // Important: This module is loaded on both mobile and desktop skin - // FIXME: Do not add anything to this module and please remove it - 'mobile.stable.common' => $wgMFResourceFileModuleBoilerplate + array( - 'dependencies' => array( - 'mobile.startup', - 'mediawiki.jqueryMsg', - 'mediawiki.util', - 'mobile.templates', - 'mobile.overlays', - 'jquery.cookie', - 'mediawiki.ui.anchor', - 'mobile.drawers', - 'mobile.toast', - 'mobile.upload.ui', - 'mobile.redirect', - ), - ), - 'mobile.references.beta' => $wgMFResourceFileModuleBoilerplate + array( 'dependencies' => array( 'mobile.references', @@ -754,8 +736,8 @@ 'dependencies' => array( 'mobile.startup', 'mobile.templates', - // Needs Drawer - 'mobile.stable.common', + 'mobile.drawers', + 'mobile.ajax', ), 'scripts' => array( 'javascripts/modules/watchstar/WatchstarApi.js', @@ -822,7 +804,6 @@ 'mobile.nearby' => $wgMFResourceFileModuleBoilerplate + array( 'dependencies' => array( 'mobile.ajax', - 'mobile.stable.common', // @todo FIXME: Kill this dependency! 'mobile.special.nearby.styles', 'mediawiki.language', @@ -1081,7 +1062,6 @@ 'mobile.special.mobilediff.scripts' => $wgMFResourceFileModuleBoilerplate + array( 'dependencies' => array( 'mobile.loggingSchemas', - 'mobile.stable.common', ), 'scripts' => array( 'javascripts/specials/mobilediff.js', @@ -1191,7 +1171,6 @@ 'mobile.loggingSchemas', // FIXME: Review the modules that follow. Ensure they are in the correct module definition. 'mobile.user', - 'mobile.stable.common', 'mediawiki.util', 'mobile.templates', 'mediawiki.language', @@ -1205,6 +1184,9 @@ 'mobile.issues', 'mobile.search', 'mobile.references', + 'mobile.redirect', + // FIXME: only load when uploads enabled + 'mobile.upload.ui', ), 'scripts' => array( 'javascripts/externals/micro.autosize.js', -- To view, visit https://gerrit.wikimedia.org/r/171732 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9f3ffdb8ac5c5eba375a880031e11d545097adf1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits