Bmansurov has uploaded a new change for review.
https://gerrit.wikimedia.org/r/171773
Change subject: Fix close icon in image overlay (alpha)
......................................................................
Fix close icon in image overlay (alpha)
Bug: 73052
Change-Id: Ia7cb2ec262f68980d26f999b4a36d05d752b3a22
---
M javascripts/modules/mediaViewer/ImageOverlay.js
M less/modules/mediaViewer.less
2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/73/171773/1
diff --git a/javascripts/modules/mediaViewer/ImageOverlay.js
b/javascripts/modules/mediaViewer/ImageOverlay.js
index c91c013..7d84579 100644
--- a/javascripts/modules/mediaViewer/ImageOverlay.js
+++ b/javascripts/modules/mediaViewer/ImageOverlay.js
@@ -1,5 +1,6 @@
( function ( M, $ ) {
var Overlay = M.require( 'Overlay' ),
+ Icon = M.require( 'Icon' ),
ImageApi = M.require( 'modules/mediaViewer/ImageApi' ),
ImageOverlay, api;
@@ -18,6 +19,11 @@
closeOnBack: true,
defaults: {
+ cancelButton: new Icon( { tagName: 'button',
+ // Uses a dark theme so swap out the icon
+ name: 'cancel-light', additionalClassNames:
'cancel',
+ label: mw.msg( 'mobile-frontend-overlay-close' )
+ } ).toHtmlString(),
detailsMsg: mw.msg( 'mobile-frontend-media-details' ),
licenseLinkMsg: mw.msg(
'mobile-frontend-media-license-link' )
},
diff --git a/less/modules/mediaViewer.less b/less/modules/mediaViewer.less
index 8dce070..5de4c8b 100644
--- a/less/modules/mediaViewer.less
+++ b/less/modules/mediaViewer.less
@@ -52,8 +52,6 @@
position: absolute;
right: 10px;
top: 10px;
- // Uses a dark theme so swap out the icon
- .background-image-svg-quick( '../images/cancel-light' );
opacity: .75;
}
--
To view, visit https://gerrit.wikimedia.org/r/171773
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7cb2ec262f68980d26f999b4a36d05d752b3a22
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
