jenkins-bot has submitted this change and it was merged. Change subject: QA: rubocop config updated to baseline again ......................................................................
QA: rubocop config updated to baseline again Change-Id: Ic399ef9bb681cfed25b0b775b0c430e338f11bd3 --- M .rubocop_todo.yml M tests/browser/features/step_definitions/messages_steps.rb 2 files changed, 3 insertions(+), 9 deletions(-) Approvals: Cmcmahon: Looks good to me, approved jenkins-bot: Verified diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 3327745..7516de2 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,5 +1,5 @@ # This configuration was generated by `rubocop --auto-gen-config` -# on 2014-11-07 14:10:43 -0700 using RuboCop version 0.27.0. +# on 2014-11-07 14:18:36 -0700 using RuboCop version 0.27.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -8,16 +8,10 @@ # Offense count: 11 # Configuration parameters: AllowURI, URISchemes. Metrics/LineLength: - Max: 113 + Max: 124 # Offense count: 3 Style/AccessorMethodName: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles. -Style/AlignHash: Enabled: false # Offense count: 1 diff --git a/tests/browser/features/step_definitions/messages_steps.rb b/tests/browser/features/step_definitions/messages_steps.rb index ad9a044..1464e39 100644 --- a/tests/browser/features/step_definitions/messages_steps.rb +++ b/tests/browser/features/step_definitions/messages_steps.rb @@ -8,7 +8,7 @@ step 'the user "' + username + '" exists' client.log_in(username, ENV["MEDIAWIKI_PASSWORD"]) client.action( 'flow', token_type: 'edit', submodule: 'new-topic', page: 'Talk:Flow QA', - nttopic:'Mention #1', ntcontent: '[[User:' + get_session_username() + ']] I wanted to say hello.' ) + nttopic:'Mention #1', ntcontent: '[[User:' + get_session_username() + ']] I wanted to say hello.' ) end When(/^I click the mark all as read button$/) do -- To view, visit https://gerrit.wikimedia.org/r/171957 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic399ef9bb681cfed25b0b775b0c430e338f11bd3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: Siebrand <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
