Cmcmahon has uploaded a new change for review. https://gerrit.wikimedia.org/r/171960
Change subject: QA: WIP rubocop updates ...................................................................... QA: WIP rubocop updates Change-Id: I580ec597dbb0d1dcd0830233995f94bc27d10278 --- M .rubocop_todo.yml M tests/browser/features/step_definitions/common_steps.rb M tests/browser/features/step_definitions/flyout_steps.rb M tests/browser/features/support/env.rb 4 files changed, 3 insertions(+), 15 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo refs/changes/60/171960/1 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 7516de2..435a0e6 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -101,13 +101,3 @@ Style/StringLiteralsInInterpolation: Enabled: false -# Offense count: 2 -# Cop supports --auto-correct. -Style/Tab: - Enabled: false - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/TrailingBlankLines: - Enabled: false diff --git a/tests/browser/features/step_definitions/common_steps.rb b/tests/browser/features/step_definitions/common_steps.rb index 4c48faf..3cedcdb 100644 --- a/tests/browser/features/step_definitions/common_steps.rb +++ b/tests/browser/features/step_definitions/common_steps.rb @@ -59,5 +59,3 @@ Then(/^I see the first heading on the page says Notifications$/) do expect(on(ArticlePage).first_heading_span).to match "Notifications" end - - diff --git a/tests/browser/features/step_definitions/flyout_steps.rb b/tests/browser/features/step_definitions/flyout_steps.rb index 59e63e8..e571305 100644 --- a/tests/browser/features/step_definitions/flyout_steps.rb +++ b/tests/browser/features/step_definitions/flyout_steps.rb @@ -12,4 +12,4 @@ Then(/^I see the notification flyout button$/) do expect(on(ArticlePage).flyout_link_container_element.when_present).to be_visible -end \ No newline at end of file +end diff --git a/tests/browser/features/support/env.rb b/tests/browser/features/support/env.rb index b0ff585..0dd9ecb 100644 --- a/tests/browser/features/support/env.rb +++ b/tests/browser/features/support/env.rb @@ -4,9 +4,9 @@ Bundler.require if ( ENV['PAGE_WAIT_TIMEOUT'] ) then - PageObject.default_page_wait = ENV['PAGE_WAIT_TIMEOUT'].to_i + PageObject.default_page_wait = ENV['PAGE_WAIT_TIMEOUT'].to_i end if ( ENV['ELEMENT_WAIT_TIMEOUT'] ) then - PageObject.default_element_wait = ENV['ELEMENT_WAIT_TIMEOUT'].to_i + PageObject.default_element_wait = ENV['ELEMENT_WAIT_TIMEOUT'].to_i end -- To view, visit https://gerrit.wikimedia.org/r/171960 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I580ec597dbb0d1dcd0830233995f94bc27d10278 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
