jenkins-bot has submitted this change and it was merged.
Change subject: Tests: Talk overlay
......................................................................
Tests: Talk overlay
Change-Id: Ibdc737837ad5f72ef46a1f0108a8aaf26496a501
---
M tests/qunit/modules/talk/test_TalkOverlay.js
1 file changed, 28 insertions(+), 1 deletion(-)
Approvals:
Robmoen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/qunit/modules/talk/test_TalkOverlay.js
b/tests/qunit/modules/talk/test_TalkOverlay.js
index c666275..add0361 100644
--- a/tests/qunit/modules/talk/test_TalkOverlay.js
+++ b/tests/qunit/modules/talk/test_TalkOverlay.js
@@ -6,7 +6,17 @@
setup: function() {
this.sandbox.stub( M.pageApi, 'getPage' ).withArgs( 'Talk:No
exist' ).returns(
$.Deferred().reject( 'missingtitle' )
+ ).withArgs( 'Talk:Topic' ).returns(
+ $.Deferred().resolve( {
+ title: 'Talk:Topic',
+ id: 1,
+ lead: '',
+ sections: [
+ { id: 50, line: 'Topic 1' }
+ ]
+ } )
);
+
this.user = mw.user.getName() || '';
},
teardown: function() {
@@ -30,11 +40,28 @@
assert.strictEqual( overlay.$( 'button.add' ).length, 0, 'There is no
"Add discussion" button' );
} );
-QUnit.test( '#TalkOverlay (logged in)', 1, function( assert ) {
+QUnit.test( '#TalkOverlay (logged in)', 2, function( assert ) {
mw.config.set( 'wgUserName', 'FlorianSW' );
var overlay = new TalkOverlay( { title: 'Talk:No exist' } );
assert.ok( overlay.$( 'button.add' ).length > 0, 'There is an "Add
discussion" button' );
+ assert.strictEqual( $.trim( overlay.$( '.content-header' ).text() ),
+ mw.msg( 'mobile-frontend-talk-explained-empty' ),
+ 'Check the header knows it is empty.' );
+} );
+
+
+QUnit.test( '#TalkOverlay (existing page lists section headings)', 4,
function( assert ) {
+ var overlay = new TalkOverlay( { title: 'Talk:Topic' } );
+
+ assert.ok( overlay.$( '.page-list li' ).length === 1, 'One topic
heading is listed' );
+ assert.strictEqual( overlay.$( '.page-list li a' ).eq( 0 ).text(),
'Topic 1',
+ 'The text of the second item is the section heading.' );
+ assert.strictEqual( overlay.$( '.page-list li a' ).data( 'id' ), 50,
+ 'The data id is set.' );
+ assert.strictEqual( $.trim( overlay.$( '.content-header' ).text() ),
+ mw.msg( 'mobile-frontend-talk-explained' ),
+ 'Check the header knows it is not empty.' );
} );
}( mw.mobileFrontend, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/171881
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdc737837ad5f72ef46a1f0108a8aaf26496a501
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
