Smuggli has submitted this change and it was merged.
Change subject: Don't call ApiResult::getResult()
......................................................................
Don't call ApiResult::getResult()
If $apiResult->getResult() !== $apiResult, you've got bigger problems.
Change-Id: I9d5f2617d904de7c1c06a936d9a6cd68cd04f73b
---
M UserSidebar/api/ApiSidebar.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Smuggli: Verified; Looks good to me, approved
diff --git a/UserSidebar/api/ApiSidebar.php b/UserSidebar/api/ApiSidebar.php
index 5012732..a648554 100644
--- a/UserSidebar/api/ApiSidebar.php
+++ b/UserSidebar/api/ApiSidebar.php
@@ -32,7 +32,7 @@
else
$sContent = $oView->execute();
$result['usersidebar'][$oView->getId()][] = $sContent;
-
$apiResult->getResult()->setIndexedTagName($result['usersidebar'][$oView->getId()],
'content');
+
$apiResult->setIndexedTagName($result['usersidebar'][$oView->getId()],
'content');
} else {
wfDebugLog( 'BS::Skin', 'BlueSpiceTemplate::printViews:
Invalid view.' );
}
@@ -81,4 +81,4 @@
public function getVersion() {
return __CLASS__;
}
-}
\ No newline at end of file
+}
--
To view, visit https://gerrit.wikimedia.org/r/171895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d5f2617d904de7c1c06a936d9a6cd68cd04f73b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Pigpen <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: Smuggli <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
