Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172097
Change subject: Hide HHVM tag on Special:{Contributions,RecentChanges,...}
......................................................................
Hide HHVM tag on Special:{Contributions,RecentChanges,...}
The coming weeks will see HHVM rolled out to progressively more users, which
will make the HHVM change tag even more ubiquitous than it is today. A small
bug significant number of users have said that they find the tag irritating or
confusing, so let's temporarily hide it from the interface. (We only need this
until the migration is complete, because after that we can just go back and
delete the tag from the database.)
With this patch, the HHVM tag is not shown in change lists, but you can still
filter on it.
This could be implemented as a proper feature, configurable by adding items to
a $wgHiddenChangeTags array. I decided against doing that because I'm uneasy
about its application beyond this particular case.
My plan is to cherry-pick this change to the production branches (if it gets
merged) and leave it in master until the tag is expunged. This will happen long
before the 1.25 branch date of April 15, 2015.
Bug: 73181
Change-Id: Iec9befeba4fe77df0ddd4f056d82b3d4e2dd2199
---
M includes/ChangeTags.php
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/97/172097/1
diff --git a/includes/ChangeTags.php b/includes/ChangeTags.php
index a3c2360..87c6ce5 100644
--- a/includes/ChangeTags.php
+++ b/includes/ChangeTags.php
@@ -34,13 +34,17 @@
public static function formatSummaryRow( $tags, $page ) {
global $wgLang;
+ $tags = explode( ',', $tags );
+
+ // XXX(Ori Livneh, 2014-11-08): remove once bug 73181 is
resolved.
+ $tags = array_diff( $tags, array( 'HHVM', '' ) );
+
if ( !$tags ) {
return array( '', array() );
}
$classes = array();
- $tags = explode( ',', $tags );
$displayTags = array();
foreach ( $tags as $tag ) {
$displayTags[] = Xml::tags(
--
To view, visit https://gerrit.wikimedia.org/r/172097
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec9befeba4fe77df0ddd4f056d82b3d4e2dd2199
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
