jenkins-bot has submitted this change and it was merged.
Change subject: Fix bottom margin issues with portrait images
......................................................................
Fix bottom margin issues with portrait images
This was happening due to:
* Stale CSS selector
* Incorrect margin values
Also added missing triangle pokey for a particular
orientation of the hovercard.
Bug: 71872
Change-Id: Ic4986f9cee2a92b29548ef21f9bec3f2c2117e98
---
M resources/ext.popups.core.less
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
AndyRussG: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.popups.core.less b/resources/ext.popups.core.less
index b4f5471..931fc60 100644
--- a/resources/ext.popups.core.less
+++ b/resources/ext.popups.core.less
@@ -120,7 +120,7 @@
width: 450px;
> div > a > svg {
- margin-bottom: -5px;
+ margin-bottom: -7px;
}
.mwe-popups-extract {
@@ -226,7 +226,7 @@
> div > a > svg {
margin: 0;
margin-top: -8px;
- margin-bottom: -5px;
+ margin-bottom: -7px;
position: absolute;
z-index: 100;
/* @noflip */
@@ -249,7 +249,8 @@
min-height: 242px;
&:after {
- border: none;
+ z-index: 91;
+ .mwe-popups-border-triangle-bottom(8px, 421px,
#fff);
}
&:before {
@@ -257,7 +258,7 @@
.mwe-popups-border-triangle-bottom(9px, 420px,
#bbb);
}
- > a > svg {
+ > div > a > svg {
position: absolute;
z-index: 100;
margin: 0;
--
To view, visit https://gerrit.wikimedia.org/r/165705
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4986f9cee2a92b29548ef21f9bec3f2c2117e98
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
