jenkins-bot has submitted this change and it was merged.
Change subject: Ensure notifications overlay code runs
......................................................................
Ensure notifications overlay code runs
Modules are defined as strings, not arrays, in
MobileContext#getContextSpecificModules.
Also add group user to ensure browser loads from cached anonymous
pages.
Bug: 73149
Bug: 73198
Change-Id: I0cd04a2dc62f7fd353c9e0584fec82fc68321dbf
---
M includes/Resources.php
M includes/skins/SkinMinerva.php
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Phuedx: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Resources.php b/includes/Resources.php
index 9e911a4..a91c4e6 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -951,6 +951,7 @@
'scripts' => array(
'javascripts/modules/notifications/notifications.js',
),
+ 'group' => 'user',
),
'mobile.notifications.overlay' => $wgMFResourceFileModuleBoilerplate +
array(
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 8347569..3d1455b 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -864,7 +864,7 @@
$modules[] = 'mobile.usermodule';
if ( $this->useEcho() ) {
- $modules['notifications'] = array(
'mobile.notifications' );
+ $modules['notifications'] =
'mobile.notifications';
}
if ( $this->isCurrentPageEditable() ) {
--
To view, visit https://gerrit.wikimedia.org/r/172006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0cd04a2dc62f7fd353c9e0584fec82fc68321dbf
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
