jenkins-bot has submitted this change and it was merged.
Change subject: Be consistent in "modules-to-load" declaration
......................................................................
Be consistent in "modules-to-load" declaration
Follow up:I0cd04a2dc62f7fd353c9e0584fec82fc68321dbf
Bug: 73198
Change-Id: I7caa62061c480d1f2817b27582d1ab30c6038a2a
---
M includes/skins/SkinMinerva.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Phuedx: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 3d1455b..4d806a7 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -864,7 +864,7 @@
$modules[] = 'mobile.usermodule';
if ( $this->useEcho() ) {
- $modules['notifications'] =
'mobile.notifications';
+ $modules[] = 'mobile.notifications';
}
if ( $this->isCurrentPageEditable() ) {
--
To view, visit https://gerrit.wikimedia.org/r/172113
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7caa62061c480d1f2817b27582d1ab30c6038a2a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits