jenkins-bot has submitted this change and it was merged.
Change subject: Show intermediate loader when loading image overlay
......................................................................
Show intermediate loader when loading image overlay
Otherwise it looks like it didn't work on a slow connection
Change-Id: I7d4932aa618ccc9c50094b2c8a184a700eae098b
---
M javascripts/modules/mediaViewer/init.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/mediaViewer/init.js
b/javascripts/modules/mediaViewer/init.js
index 2c709cb..cd37a34 100644
--- a/javascripts/modules/mediaViewer/init.js
+++ b/javascripts/modules/mediaViewer/init.js
@@ -18,7 +18,7 @@
// Add route
function loadImageOverlay( title ) {
var result = $.Deferred();
- mw.loader.using( 'mobile.mediaViewer', function () {
+ M.loadModule( 'mobile.mediaViewer' ).done( function () {
var caption = $( 'a[href*="' + title + '"]' ).siblings(
'.thumbcaption' ).text(),
ImageOverlay = M.require(
'modules/mediaViewer/ImageOverlay' );
--
To view, visit https://gerrit.wikimedia.org/r/171986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d4932aa618ccc9c50094b2c8a184a700eae098b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
