Matanya has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/172220

Change subject: apache: very minor lint
......................................................................

apache: very minor lint

Change-Id: I0c6a01a01760881def442773473050a52b85db4d
---
M modules/apache/manifests/conf.pp
M modules/apache/manifests/monitoring.pp
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/20/172220/1

diff --git a/modules/apache/manifests/conf.pp b/modules/apache/manifests/conf.pp
index a6a17a5..c31d54a 100644
--- a/modules/apache/manifests/conf.pp
+++ b/modules/apache/manifests/conf.pp
@@ -96,8 +96,8 @@
 
     if $replaces != undef {
         file { "${title_safe}_${replaces}":
-            path   => "/etc/apache2/${replaces}",
             ensure => absent,
+            path   => "/etc/apache2/${replaces}",
         }
     }
 }
diff --git a/modules/apache/manifests/monitoring.pp 
b/modules/apache/manifests/monitoring.pp
index 4dc9bd1..026ac9c 100644
--- a/modules/apache/manifests/monitoring.pp
+++ b/modules/apache/manifests/monitoring.pp
@@ -16,7 +16,7 @@
     diamond::collector { 'Httpd':
         ensure   => absent,
         settings => {
-            path => "${::site}.${cluster}.httpd",
+            path => "${::site}.${::cluster}.httpd",
             urls => 'http://127.0.0.1/server-status?auto'
         },
     }

-- 
To view, visit https://gerrit.wikimedia.org/r/172220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c6a01a01760881def442773473050a52b85db4d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Matanya <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to