Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172247
Change subject: Remove unused newSnakFormatter method in WikibaseClient
......................................................................
Remove unused newSnakFormatter method in WikibaseClient
Change-Id: I5fa198d152532ac4e89a246b5348a8aac702aeff
---
M client/includes/WikibaseClient.php
M client/tests/phpunit/includes/WikibaseClientTest.php
2 files changed, 0 insertions(+), 22 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/47/172247/1
diff --git a/client/includes/WikibaseClient.php
b/client/includes/WikibaseClient.php
index 6ece070..5161ee8 100644
--- a/client/includes/WikibaseClient.php
+++ b/client/includes/WikibaseClient.php
@@ -42,7 +42,6 @@
use Wikibase\Lib\OutputFormatValueFormatterFactory;
use Wikibase\Lib\PropertyInfoDataTypeLookup;
use Wikibase\Lib\Serializers\ForbiddenSerializer;
-use Wikibase\Lib\SnakFormatter;
use Wikibase\Lib\Store\EntityContentDataCodec;
use Wikibase\Lib\Store\EntityLookup;
use Wikibase\Lib\WikibaseDataTypeBuilders;
@@ -216,18 +215,6 @@
}
return $this->propertyDataTypeLookup;
- }
-
- /**
- * @since 0.4
- *
- * @param string $format The desired format, use
SnakFormatter::FORMAT_XXX
- * @param FormatterOptions $options
- *
- * @return SnakFormatter
- */
- public function newSnakFormatter( $format =
SnakFormatter::FORMAT_PLAIN, FormatterOptions $options ) {
- return $this->getSnakFormatterFactory()->getSnakFormatter(
$format, $options );
}
/**
diff --git a/client/tests/phpunit/includes/WikibaseClientTest.php
b/client/tests/phpunit/includes/WikibaseClientTest.php
index f93292b..3c83767 100644
--- a/client/tests/phpunit/includes/WikibaseClientTest.php
+++ b/client/tests/phpunit/includes/WikibaseClientTest.php
@@ -8,7 +8,6 @@
use ValueFormatters\FormatterOptions;
use Wikibase\Client\WikibaseClient;
use Wikibase\DataModel\Entity\Item;
-use Wikibase\Lib\SnakFormatter;
use Wikibase\SettingsArray;
/**
@@ -38,14 +37,6 @@
public function testGetPropertyDataTypeLookupReturnType() {
$returnValue =
$this->getDefaultInstance()->getPropertyDataTypeLookup();
$this->assertInstanceOf(
'Wikibase\DataModel\Entity\PropertyDataTypeLookup', $returnValue );
- }
-
- public function testNewSnakFormatterReturnType() {
- $returnValue = $this->getDefaultInstance()->newSnakFormatter(
- SnakFormatter::FORMAT_PLAIN,
- new FormatterOptions()
- );
- $this->assertInstanceOf( 'Wikibase\Lib\SnakFormatter',
$returnValue );
}
public function testGetStringNormalizerReturnType() {
--
To view, visit https://gerrit.wikimedia.org/r/172247
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5fa198d152532ac4e89a246b5348a8aac702aeff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
