jenkins-bot has submitted this change and it was merged.
Change subject: Improved/additional logging for $wgTitle abuses
......................................................................
Improved/additional logging for $wgTitle abuses
Change-Id: I6599aa8abe30c1888ab5df023a0d4bf346315400
---
M includes/cache/MessageCache.php
M includes/context/RequestContext.php
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/cache/MessageCache.php b/includes/cache/MessageCache.php
index 99dafa6..7cd1377 100644
--- a/includes/cache/MessageCache.php
+++ b/includes/cache/MessageCache.php
@@ -1059,6 +1059,7 @@
wfProfileIn( __METHOD__ );
if ( !$title || !$title instanceof Title ) {
global $wgTitle;
+ wfDebugLog( 'GlobalTitleFail', __METHOD__ . ' called by
' . wfGetAllCallers() . ' with no title set.' );
$title = $wgTitle;
}
// Sometimes $wgTitle isn't set either...
diff --git a/includes/context/RequestContext.php
b/includes/context/RequestContext.php
index 059f18c..d620be9 100644
--- a/includes/context/RequestContext.php
+++ b/includes/context/RequestContext.php
@@ -140,7 +140,7 @@
if ( $this->title === null ) {
global $wgTitle; # fallback to $wg till we can improve
this
$this->title = $wgTitle;
- wfDebugLog( 'GlobalTitleFail', __METHOD__ . ' called by
' . wfGetCaller() . ' with no title set.' );
+ wfDebugLog( 'GlobalTitleFail', __METHOD__ . ' called by
' . wfGetAllCallers() . ' with no title set.' );
}
return $this->title;
--
To view, visit https://gerrit.wikimedia.org/r/171864
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6599aa8abe30c1888ab5df023a0d4bf346315400
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
