jenkins-bot has submitted this change and it was merged.

Change subject: QA update quotes for string interpolation
......................................................................


QA update quotes for string interpolation

Change-Id: Ic74333eea147183f407ffbe2b5319bb4683b5833
---
M .rubocop_todo.yml
M tests/browser/features/step_definitions/common_steps.rb
2 files changed, 1 insertion(+), 6 deletions(-)

Approvals:
  Cmcmahon: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 5c3b984..5652fda 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -29,8 +29,3 @@
 Style/StringLiterals:
   Enabled: false
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiteralsInInterpolation:
-  Enabled: false
diff --git a/tests/browser/features/step_definitions/common_steps.rb 
b/tests/browser/features/step_definitions/common_steps.rb
index e54203f..b7c6264 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -3,7 +3,7 @@
 end
 
 def get_session_username
-  "#{ENV["MEDIAWIKI_USER"]}_#{@browser.name}"
+  "#{ENV['MEDIAWIKI_USER']}_#{@browser.name}"
 end
 
 def get_session_username_b

-- 
To view, visit https://gerrit.wikimedia.org/r/172401
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic74333eea147183f407ffbe2b5319bb4683b5833
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to