jenkins-bot has submitted this change and it was merged.
Change subject: Fix MobileWebWikiGrokError event logging
......................................................................
Fix MobileWebWikiGrokError event logging
* Remove unused fields
* Update schema revision
Bug: 73162
Change-Id: If213972e7263190bdc976d3333ef2b208edaf186
---
M includes/MobileFrontend.hooks.php
M javascripts/modules/wikigrok/wikigrok.js
2 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index 989d855..e34ab5e 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -868,7 +868,7 @@
'MobileWebCta' => 5972684,
'MobileWebClickTracking' => 5929948,
'MobileWebWikiGrok' => 10352247,
- 'MobileWebWikiGrokError' => 10352248,
+ 'MobileWebWikiGrokError' => 10353516,
);
$schemas += $mobileEventLoggingSchemas;
diff --git a/javascripts/modules/wikigrok/wikigrok.js
b/javascripts/modules/wikigrok/wikigrok.js
index 10f5a32..57d30a9 100644
--- a/javascripts/modules/wikigrok/wikigrok.js
+++ b/javascripts/modules/wikigrok/wikigrok.js
@@ -154,8 +154,6 @@
} ).fail( function () {
var data = {
error: 'no-impression-cannot-load-interface',
- itemId: wikidataID,
- title: mw.config.get( 'wgTitle' ),
taskType: 'version ' + version.name,
taskToken: mw.user.generateRandomSessionId(),
userToken: getUserToken(),
--
To view, visit https://gerrit.wikimedia.org/r/172412
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If213972e7263190bdc976d3333ef2b208edaf186
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
