Matthias Mullie has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/172429

Change subject: Logged-in users should save null values to rev_user_id
......................................................................

Logged-in users should save null values to rev_user_id

Bug: 73153
Change-Id: Ic17d1210aa4dd37652e90a5f53c1309ed96361f8
---
M includes/Model/UserTuple.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/29/172429/1

diff --git a/includes/Model/UserTuple.php b/includes/Model/UserTuple.php
index dc8ca63..eb5a091 100644
--- a/includes/Model/UserTuple.php
+++ b/includes/Model/UserTuple.php
@@ -23,7 +23,7 @@
        public $id;
 
        /**
-        * @param string The ip of the user, blank string if logged in.
+        * @param string|null The ip of the user, null if logged in.
         */
        public $ip;
 
@@ -56,7 +56,7 @@
 
                $this->wiki = $wiki;
                $this->id = $id;
-               $this->ip = (string)$ip;
+               $this->ip = (string)$ip ?: null;
        }
 
        public static function newFromUser( User $user ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/172429
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic17d1210aa4dd37652e90a5f53c1309ed96361f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to