[MediaWiki-commits] [Gerrit] Alpha: Hide notifications bell icon when spinner is shown - change (mediawiki...MobileFrontend)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Alpha: Hide notifications bell icon when spinner is shown
......................................................................


Alpha: Hide notifications bell icon when spinner is shown

Bug: 73058
Change-Id: If5475988dcfc097e17acd636d9b6214c994d98a4
---
M javascripts/modules/notifications/notifications.js
1 file changed, 9 insertions(+), 4 deletions(-)

Approvals:
  Robmoen: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/javascripts/modules/notifications/notifications.js 
b/javascripts/modules/notifications/notifications.js
index 19832c3..98b753f 100644
--- a/javascripts/modules/notifications/notifications.js
+++ b/javascripts/modules/notifications/notifications.js
@@ -3,7 +3,7 @@
  * with the Toast notifications defined by common/toast.js.
  */
 ( function ( M, $ ) {
-       var
+       var Icon = M.require( 'Icon' ),
                mainmenu = M.require( 'mainmenu' ),
                $btn = $( '#secondary-button.user-button' );
 
@@ -15,11 +15,16 @@
         * @returns {jQuery.Deferred}
        */
        function loadModuleScript( moduleName ) {
-               var d = $.Deferred();
+               var d = $.Deferred(),
+                       loadingIcon = new Icon( {
+                               tagName: 'a',
+                               additionalClassNames: 'loading'
+                       } ).toHtmlString();
 
-               $btn.addClass( 'loading' );
+               $btn.hide().after( loadingIcon );
                mw.loader.using( moduleName, function () {
-                       $btn.removeClass( 'loading' );
+                       $btn.next( '.loading' ).remove();
+                       $btn.show();
                        d.resolve();
                } );
                return d;

-- 
To view, visit https://gerrit.wikimedia.org/r/172425
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If5475988dcfc097e17acd636d9b6214c994d98a4
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org>
Gerrit-Reviewer: Awjrichards <aricha...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Robmoen <rm...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits