Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172467
Change subject: ApiResponse: return success or die with error if logging fails
......................................................................
ApiResponse: return success or die with error if logging fails
Change-Id: Ia6fbb60d56ab9e50619e761b1210ba8933263642
---
M includes/api/ApiResponse.php
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiGrok
refs/changes/67/172467/1
diff --git a/includes/api/ApiResponse.php b/includes/api/ApiResponse.php
index 875d134..4c9800a 100644
--- a/includes/api/ApiResponse.php
+++ b/includes/api/ApiResponse.php
@@ -53,12 +53,17 @@
'value' => $claim['value'],
'response' => $claim['correct'],
);
- $eventLogger->logEvent(
+ $eventLogged = $eventLogger->logEvent(
self::SCHEMA,
self::SCHEMA_REV_ID,
$event
);
+ if ( !$eventLogged ) {
+ $this->dieUsage( 'Logging one or more claims
failed', 'loggingfailed' );
+ }
}
+
+ $this->getResult()->addValue( 'query', $this->getModuleName(),
'success' );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/172467
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6fbb60d56ab9e50619e761b1210ba8933263642
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiGrok
Gerrit-Branch: master
Gerrit-Owner: Robmoen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
