jenkins-bot has submitted this change and it was merged.
Change subject: Allow for null answer in response api.
......................................................................
Allow for null answer in response api.
As isset on null is false
Change-Id: Ib17935607747a6210104a3f9767753e09ba36514
---
M includes/api/ApiResponse.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/api/ApiResponse.php b/includes/api/ApiResponse.php
index 875d134..59fac59 100644
--- a/includes/api/ApiResponse.php
+++ b/includes/api/ApiResponse.php
@@ -72,7 +72,7 @@
private function validateClaim( array $claim ) {
if (
- !isset( $claim['correct'] )
+ !array_key_exists( 'correct', $claim )
|| !( is_bool( $claim['correct'] ) || $claim['correct']
=== null )
|| !isset( $claim['propid'] )
|| !isset( $claim['prop'] )
--
To view, visit https://gerrit.wikimedia.org/r/172463
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib17935607747a6210104a3f9767753e09ba36514
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiGrok
Gerrit-Branch: master
Gerrit-Owner: Robmoen <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
