Christopher Johnson (WMDE) has submitted this change and it was merged.
Change subject: bump phabricator version in composer.json
......................................................................
bump phabricator version in composer.json
Change-Id: Ia34aa09a585725b71dcb5a922730c58bd9ea3fc5
---
M composer.json
M src/view/BurndownDataView.php
2 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Christopher Johnson (WMDE): Verified; Looks good to me, approved
diff --git a/composer.json b/composer.json
index 265e1c8..204fd4b 100644
--- a/composer.json
+++ b/composer.json
@@ -14,7 +14,7 @@
"type": "git",
"reference": "master"
},
- "version": "1.0.0"
+ "version": "1.0.1"
}
}
],
@@ -36,6 +36,6 @@
},
"require": {
"php": ">=5.3.2",
- "phabricator/phabricator": "1.0.0"
+ "phabricator/phabricator": "1.0.1"
}
-}
\ No newline at end of file
+}
diff --git a/src/view/BurndownDataView.php b/src/view/BurndownDataView.php
index 916f2a2..8a2888d 100644
--- a/src/view/BurndownDataView.php
+++ b/src/view/BurndownDataView.php
@@ -259,7 +259,7 @@
}
- private function buildTaskMap ($tasks, $edges) {
+ private function buildTaskMap ($edges) {
$map = array();
foreach ($this->tasks as $task) {
if ($parents =
@@ -295,7 +295,7 @@
private function buildTasksTree($order, $reverse) {
$query = id(new SprintQuery());
$edges = $query->getEdges($this->tasks);
- $map = $this->buildTaskMap($this->tasks, $edges);
+ $map = $this->buildTaskMap($edges);
// We also collect the phids we need to fetch owner information
$handle_phids = array();
@@ -307,6 +307,7 @@
// Now we loop through the tasks, and add them to the output
$output = array();
+ $rows = array();
foreach ($this->tasks as $task) {
// If parents is set, it means this task has a parent in this sprint so
// skip it, the parent will handle adding this task to the output
--
To view, visit https://gerrit.wikimedia.org/r/172470
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia34aa09a585725b71dcb5a922730c58bd9ea3fc5
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <[email protected]>
Gerrit-Reviewer: Christopher Johnson (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
