Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/172472
Change subject: Skeletal browser tests ...................................................................... Skeletal browser tests Change-Id: I9b767b7838c12c3d728571f4334eeecbdb9c06f1 --- A tests/browser/features/banners.feature A tests/browser/features/step_definitions/banner_steps.rb A tests/browser/features/support/env.rb A tests/browser/features/support/hooks.rb A tests/browser/features/throttling.feature-disabled 5 files changed, 56 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice refs/changes/72/172472/1 diff --git a/tests/browser/features/banners.feature b/tests/browser/features/banners.feature new file mode 100644 index 0000000..ac4dbdc --- /dev/null +++ b/tests/browser/features/banners.feature @@ -0,0 +1,14 @@ +@chrome @firefox +Feature: Crude banner display + + Scenario: Banner one is displayed for low roll + Given I roll 0.25 for banner choice + Then I see banner one + + Scenario: Banner two is displayed for mid roll + Given I roll 0.50 for banner choice + Then I see banner two + + Scenario: No banner is displayed for high roll + Given I roll 0.75 for banner choice + Then I see no banner diff --git a/tests/browser/features/step_definitions/banner_steps.rb b/tests/browser/features/step_definitions/banner_steps.rb new file mode 100644 index 0000000..a7bb148 --- /dev/null +++ b/tests/browser/features/step_definitions/banner_steps.rb @@ -0,0 +1,11 @@ +Given(/^I roll ([0-9.]+) for banner choice$/) do + # TODO +end + +Then(/^I see banner (\w+)$/) do + # TODO +end + +Then(/^I see no banner$/) do + # TODO +end diff --git a/tests/browser/features/support/env.rb b/tests/browser/features/support/env.rb new file mode 100644 index 0000000..cdbe1a4 --- /dev/null +++ b/tests/browser/features/support/env.rb @@ -0,0 +1,12 @@ +require 'rubygems' +require 'bundler/setup' + +Bundler.require + +if ENV['PAGE_WAIT_TIMEOUT'] + PageObject.default_page_wait = ENV['PAGE_WAIT_TIMEOUT'].to_i +end + +if ENV['ELEMENT_WAIT_TIMEOUT'] + PageObject.default_element_wait = ENV['ELEMENT_WAIT_TIMEOUT'].to_i +end diff --git a/tests/browser/features/support/hooks.rb b/tests/browser/features/support/hooks.rb new file mode 100644 index 0000000..7da02d5 --- /dev/null +++ b/tests/browser/features/support/hooks.rb @@ -0,0 +1,3 @@ +# Allow running of bundle exec cucumber --dry-run -f stepdefs +require 'mediawiki_selenium' +require 'page-object' diff --git a/tests/browser/features/throttling.feature-disabled b/tests/browser/features/throttling.feature-disabled new file mode 100644 index 0000000..fcf039d --- /dev/null +++ b/tests/browser/features/throttling.feature-disabled @@ -0,0 +1,16 @@ +@chrome @firefox +Feature: Campaign throttling + + Background: + Given the following campaigns exist: + | preferred | throttle | banners | + | normal | 60 | one | + | low | 100 | two | + + Scenario: Throttled banner has higher priority + Given I roll 0.59 for banner choice + Then I see banner one + + Scenario: Throttled banner yields some allocations + Given I roll 0.61 for banner choice + Then I see banner two -- To view, visit https://gerrit.wikimedia.org/r/172472 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9b767b7838c12c3d728571f4334eeecbdb9c06f1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Awight <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
