Subramanya Sastry has submitted this change and it was merged. Change subject: Deep-freeze cache returns and enable strict mode ......................................................................
Deep-freeze cache returns and enable strict mode This exposed a few bugs (primarily missing var declarations), which are fixed. It would for example have caught the shallow clone bug we just fixed, and should catch similar bugs early in the future. TODO / issues this exposed: Avoid attempted tsr modification in ext.core.TemplateHandler.js:306:29. This is fixed for now by cloning the tokens, but should really be avoided by stripping the tsr before caching the tokens (anything in phase 1 will work for example). Change-Id: I6a1a07de7ac333f31da9cf0ae9ed20e5507bacba --- M js/lib/ext.Cite.js M js/lib/ext.cite.taghook.ref.js M js/lib/ext.core.AttributeExpander.js M js/lib/ext.core.BehaviorSwitchHandler.js M js/lib/ext.core.LinkHandler.js M js/lib/ext.core.ListHandler.js M js/lib/ext.core.NoIncludeOnly.js M js/lib/ext.core.ParagraphWrapper.js M js/lib/ext.core.ParserFunctions.js M js/lib/ext.core.PreHandler.js M js/lib/ext.core.QuoteTransformer.js M js/lib/ext.core.TemplateHandler.js M js/lib/ext.util.TokenAndAttrCollector.js M js/lib/ext.util.TokenCollector.js M js/lib/mediawiki.ApiRequest.js M js/lib/mediawiki.DOMPostProcessor.js M js/lib/mediawiki.HTML5TreeBuilder.node.js M js/lib/mediawiki.Title.js M js/lib/mediawiki.TokenTransformManager.js M js/lib/mediawiki.Util.js M js/lib/mediawiki.WikitextSerializer.js M js/lib/mediawiki.parser.defines.js M js/lib/mediawiki.parser.environment.js M js/lib/mediawiki.parser.js M js/lib/mediawiki.tokenizer.peg.js M js/lib/mediawiki.wikitext.constants.js M js/lib/pegTokenizer.pegjs.txt M js/tests/parserTests.js 28 files changed, 129 insertions(+), 29 deletions(-) Approvals: Subramanya Sastry: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/30741 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a1a07de7ac333f31da9cf0ae9ed20e5507bacba Gerrit-PatchSet: 11 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: GWicke <[email protected]> Gerrit-Reviewer: GWicke <[email protected]> Gerrit-Reviewer: MarkTraceur <[email protected]> Gerrit-Reviewer: Subramanya Sastry <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
