saper has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/172662

Change subject: Mark TestORMRowTest as broken
......................................................................

Mark TestORMRowTest as broken

This test succeeds when run standalone,
but fails when a whole suite is run.

Bug: 37601
Change-Id: I6208f4701b88594628fb4bac4b9aaaebdd5a7dc8
---
M tests/phpunit/includes/db/TestORMRowTest.php
1 file changed, 11 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/62/172662/1

diff --git a/tests/phpunit/includes/db/TestORMRowTest.php 
b/tests/phpunit/includes/db/TestORMRowTest.php
index ca31cf9..6cbb162 100644
--- a/tests/phpunit/includes/db/TestORMRowTest.php
+++ b/tests/phpunit/includes/db/TestORMRowTest.php
@@ -24,6 +24,14 @@
  *
  * @ingroup Test
  *
+ * @licence GNU GPL v2+
+ * @author Jeroen De Dauw < [email protected] >
+ */
+require_once __DIR__ . "/ORMRowTest.php";
+
+/**
+ * @covers TestORMRow
+ *
  * @group ORM
  *
  * The database group has as a side effect that temporal database tables are 
created. This makes
@@ -35,13 +43,9 @@
  * that hold the first tests in a pending state awaiting access to the 
database.
  * @group medium
  *
- * @licence GNU GPL v2+
- * @author Jeroen De Dauw < [email protected] >
- */
-require_once __DIR__ . "/ORMRowTest.php";
-
-/**
- * @covers TestORMRow
+ * @group Broken
+ * Bug 37601: This test cannot be run in isolation; it succeeds
+ * when run isolated and fails when a whole suite is run
  */
 class TestORMRowTest extends ORMRowTest {
 

-- 
To view, visit https://gerrit.wikimedia.org/r/172662
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6208f4701b88594628fb4bac4b9aaaebdd5a7dc8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: saper <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to