[MediaWiki-commits] [Gerrit] Fix visibility issues in Scribunto tests - change (mediawiki...Wikibase)

[WMDE]

Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/172709

Change subject: Fix visibility issues in Scribunto tests
......................................................................

Fix visibility issues in Scribunto tests

This needs If6d2705 to be merged first.

Change-Id: I1f71d9d4b42518bdc2ab4bd35b39793c36438dd3
---
M 
client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php
M 
client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryNoArbitraryAccessTest.php
M client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryTest.php
M 
client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
4 files changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/09/172709/1

diff --git 
a/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php
 
b/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php
index a87eda4..fc39ec9 100644
--- 
a/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php
+++ 
b/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php
@@ -20,9 +20,10 @@
  * @author Marius Hoch < h...@online.de >
  */
 class Scribunto_LuaWikibaseEntityLibraryTest extends 
Scribunto_LuaWikibaseLibraryTestCase {
+
        protected static $moduleName = 'LuaWikibaseEntityLibraryTests';
 
-       function getTestModules() {
+       protected function getTestModules() {
                return parent::getTestModules() + array(
                        'LuaWikibaseEntityLibraryTests' => __DIR__ . 
'/LuaWikibaseEntityLibraryTests.lua',
                );
diff --git 
a/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryNoArbitraryAccessTest.php
 
b/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryNoArbitraryAccessTest.php
index b158e8c..4ab0759 100644
--- 
a/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryNoArbitraryAccessTest.php
+++ 
b/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryNoArbitraryAccessTest.php
@@ -18,9 +18,10 @@
  * @author Marius Hoch < h...@online.de >
  */
 class Scribunto_LuaWikibaseLibraryNoArbitraryAccessTest extends 
Scribunto_LuaWikibaseLibraryTestCase {
+
        protected static $moduleName = 
'LuaWikibaseLibraryNoArbitraryAccessTests';
 
-       function getTestModules() {
+       protected function getTestModules() {
                return parent::getTestModules() + array(
                        'LuaWikibaseLibraryNoArbitraryAccessTests' => __DIR__ . 
'/LuaWikibaseLibraryNoArbitraryAccessTests.lua',
                );
diff --git 
a/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryTest.php 
b/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryTest.php
index bba0a7f..0f26d3b 100644
--- 
a/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryTest.php
+++ 
b/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryTest.php
@@ -21,9 +21,10 @@
  * @author Marius Hoch < h...@online.de >
  */
 class Scribunto_LuaWikibaseLibraryTest extends 
Scribunto_LuaWikibaseLibraryTestCase {
+
        protected static $moduleName = 'LuaWikibaseLibraryTests';
 
-       function getTestModules() {
+       protected function getTestModules() {
                return parent::getTestModules() + array(
                        'LuaWikibaseLibraryTests' => __DIR__ . 
'/LuaWikibaseLibraryTests.lua',
                );
diff --git 
a/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
 
b/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
index 34b2876..b25f94b 100644
--- 
a/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
+++ 
b/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
@@ -100,7 +100,7 @@
                parent::setUp();
        }
 
-       public function tearDown() {
+       protected function tearDown() {
                parent::tearDown();
 
                $wikibaseClient = WikibaseClient::getDefaultInstance( 'reset' );

-- 
To view, visit https://gerrit.wikimedia.org/r/172709
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f71d9d4b42518bdc2ab4bd35b39793c36438dd3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits