Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172723
Change subject: MenuWidget: Don't close menu when you click the scroll bar
......................................................................
MenuWidget: Don't close menu when you click the scroll bar
Bug: 73284
Change-Id: I2a059933c8b99c2eb93c0f9aa8075676e5783005
---
M src/widgets/MenuWidget.js
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/23/172723/1
diff --git a/src/widgets/MenuWidget.js b/src/widgets/MenuWidget.js
index dec2baa..f44dffd 100644
--- a/src/widgets/MenuWidget.js
+++ b/src/widgets/MenuWidget.js
@@ -58,7 +58,11 @@
* @param {jQuery.Event} e Key down event
*/
OO.ui.MenuWidget.prototype.onDocumentMouseDown = function ( e ) {
- if ( !$.contains( this.$element[0], e.target ) && ( !this.$widget ||
!$.contains( this.$widget[0], e.target ) ) ) {
+ if (
+ e.target !== this.$element[0] &&
+ !$.contains( this.$element[0], e.target ) &&
+ ( !this.$widget || !$.contains( this.$widget[0], e.target ) )
+ ) {
this.toggle( false );
}
};
--
To view, visit https://gerrit.wikimedia.org/r/172723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a059933c8b99c2eb93c0f9aa8075676e5783005
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
