jenkins-bot has submitted this change and it was merged.
Change subject: Fix RuboCop warnings about multiline block syntax
......................................................................
Fix RuboCop warnings about multiline block syntax
Change-Id: I96f3e90c35cbd081367b2b532851b310f9e410e9
---
M tests/browser/features/support/pages/e2e_test_page.rb
1 file changed, 24 insertions(+), 24 deletions(-)
Approvals:
Gilles: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/support/pages/e2e_test_page.rb
b/tests/browser/features/support/pages/e2e_test_page.rb
index 0e01910..7a85d8a 100644
--- a/tests/browser/features/support/pages/e2e_test_page.rb
+++ b/tests/browser/features/support/pages/e2e_test_page.rb
@@ -44,41 +44,41 @@
span(:mmv_download_size_label, class: "mw-mmv-download-image-size")
span(:mmv_download_down_arrow_icon, class: "mw-mmv-download-select-menu")
div(:mmv_download_size_menu_container, class: "mw-mmv-download-size")
- div(:mmv_download_size_menu) {
- |page| page.mmv_download_size_menu_container_element.div_element(class:
"oo-ui-selectWidget")
- }
+ div(:mmv_download_size_menu) do |page|
+ page.mmv_download_size_menu_container_element.div_element(class:
"oo-ui-selectWidget")
+ end
divs(:mmv_download_size_options, class: "oo-ui-menuItemWidget")
a(:mmv_download_link, class: "mw-mmv-download-go-button")
a(:mmv_download_preview_link, class: "mw-mmv-download-preview-link")
div(:mmv_download_attribution_area, class: "mw-mmv-download-attribution")
p(:mmv_download_attribution_area_close_icon, class:
"mw-mmv-download-attribution-close-button")
div(:mmv_download_attribution_area_input_container, class:
"mw-mmv-download-attr-input")
- text_field(:mmv_download_attribution_area_input) {
- |page|
page.mmv_download_attribution_area_input_container_element.text_field_element
- }
+ text_field(:mmv_download_attribution_area_input) do |page|
+
page.mmv_download_attribution_area_input_container_element.text_field_element
+ end
# Options
div(:mmv_options_icon, class: "mw-mmv-options-button")
div(:mmv_options_menu_disable, class: "mw-mmv-options-disable")
div(:mmv_options_menu_enable, class: "mw-mmv-options-enable")
- button(:mmv_options_enable_button) {
- |page| page.mmv_options_menu_enable_element.div_element(class:
"mw-mmv-options-submit").button_element(class: "mw-mmv-options-submit-button")
- }
- button(:mmv_options_disable_button) {
- |page| page.mmv_options_menu_disable_element.div_element(class:
"mw-mmv-options-submit").button_element(class: "mw-mmv-options-submit-button")
- }
- button(:mmv_options_enable_cancel_button) {
- |page| page.mmv_options_menu_enable_element.div_element(class:
"mw-mmv-options-submit").button_element(class: "mw-mmv-options-cancel-button")
- }
- button(:mmv_options_disable_cancel_button) {
- |page| page.mmv_options_menu_disable_element.div_element(class:
"mw-mmv-options-submit").button_element(class: "mw-mmv-options-cancel-button")
- }
+ button(:mmv_options_enable_button) do |page|
+ page.mmv_options_menu_enable_element.div_element(class:
"mw-mmv-options-submit").button_element(class: "mw-mmv-options-submit-button")
+ end
+ button(:mmv_options_disable_button) do |page|
+ page.mmv_options_menu_disable_element.div_element(class:
"mw-mmv-options-submit").button_element(class: "mw-mmv-options-submit-button")
+ end
+ button(:mmv_options_enable_cancel_button) do |page|
+ page.mmv_options_menu_enable_element.div_element(class:
"mw-mmv-options-submit").button_element(class: "mw-mmv-options-cancel-button")
+ end
+ button(:mmv_options_disable_cancel_button) do |page|
+ page.mmv_options_menu_disable_element.div_element(class:
"mw-mmv-options-submit").button_element(class: "mw-mmv-options-cancel-button")
+ end
div(:mmv_options_disable_confirmation, class: "mw-mmv-disable-confirmation")
- div(:mmv_options_disable_x_icon) {
- |page| page.mmv_options_disable_confirmation_element.div_element(class:
"mw-mmv-confirmation-close")
- }
+ div(:mmv_options_disable_x_icon) do |page|
+ page.mmv_options_disable_confirmation_element.div_element(class:
"mw-mmv-confirmation-close")
+ end
div(:mmv_options_enable_confirmation, class: "mw-mmv-enable-confirmation")
- div(:mmv_options_enable_x_icon) {
- |page| page.mmv_options_enable_confirmation_element.div_element(class:
"mw-mmv-confirmation-close")
- }
+ div(:mmv_options_enable_x_icon) do |page|
+ page.mmv_options_enable_confirmation_element.div_element(class:
"mw-mmv-confirmation-close")
+ end
end
--
To view, visit https://gerrit.wikimedia.org/r/172717
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96f3e90c35cbd081367b2b532851b310f9e410e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
