Zfilipin has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/172732

Change subject: Fixed RuboCop Style/NegatedIf offense
......................................................................

Fixed RuboCop Style/NegatedIf offense

Bug: 72841
Change-Id: I99b7bc859e2051de03af9dcf4e1c385f1b6aa560
---
M .rubocop_todo.yml
M bin/docparser.rb
2 files changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/32/172732/1

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index d979075..0af8335 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -76,11 +76,6 @@
 Style/MultilineOperationIndentation:
   Enabled: true
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/NegatedIf:
-  Enabled: false
-
 # Offense count: 2
 # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
 Style/Next:
diff --git a/bin/docparser.rb b/bin/docparser.rb
index 1a39ec8..b82c0db 100644
--- a/bin/docparser.rb
+++ b/bin/docparser.rb
@@ -69,7 +69,7 @@
                        c.sub!(/^[ \t]*\*[ \t]?/, '') # strip leading *
 
                        m = c.match(/^@(\w+)[ \t]*(.*)/)
-                       if !m
+                       unless m
                                previous_item[:description] << c + "\n"
                                next
                        end

-- 
To view, visit https://gerrit.wikimedia.org/r/172732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I99b7bc859e2051de03af9dcf4e1c385f1b6aa560
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to