Phuedx has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172744
Change subject: Hygiene: Use the spinner class everywhere
......................................................................
Hygiene: Use the spinner class everywhere
Make all interactions with the spinner use the spinner class, rather
than the loading class.
Change-Id: Ic756a40a33f6b57b3814fb76503e9387872aedb1
---
M javascripts/modules/notifications/NotificationsOverlay.js
M javascripts/modules/talk/TalkSectionOverlay.js
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/44/172744/1
diff --git a/javascripts/modules/notifications/NotificationsOverlay.js
b/javascripts/modules/notifications/NotificationsOverlay.js
index 97319f7..de113e3 100644
--- a/javascripts/modules/notifications/NotificationsOverlay.js
+++ b/javascripts/modules/notifications/NotificationsOverlay.js
@@ -102,7 +102,7 @@
Overlay.prototype.postRender.apply( this,
options );
if ( options.notifications ||
options.errorMessage ) {
- this.$( '.loading' ).remove();
+ this.$( '.spinner' ).remove();
// Reset the badge
this.markAsRead();
}
diff --git a/javascripts/modules/talk/TalkSectionOverlay.js
b/javascripts/modules/talk/TalkSectionOverlay.js
index d55619f..841031a 100644
--- a/javascripts/modules/talk/TalkSectionOverlay.js
+++ b/javascripts/modules/talk/TalkSectionOverlay.js
@@ -39,7 +39,7 @@
self.render( options );
} );
} else {
- this.$( '.loading' ).remove();
+ this.$( '.spinner' ).remove();
this._enableComments( options.title, options.id
);
}
},
@@ -63,7 +63,7 @@
var val = $textarea.val();
if ( val ) {
$comment.hide();
- self.$( '.loading' ).show();
+ self.$( '.spinner' ).show();
// sign and add newline to front
val = '\n\n' + val + ' ~~~~';
api.getTokenWithEndpoint().done( function ( token ) {
@@ -74,7 +74,7 @@
token: token,
appendtext: val
} ).done( function (
data ) {
- self.$(
'.loading' ).hide();
+ self.$(
'.spinner' ).hide();
$comment.show();
if ( data.error
) {
$textarea.addClass( 'error' );
--
To view, visit https://gerrit.wikimedia.org/r/172744
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic756a40a33f6b57b3814fb76503e9387872aedb1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
