Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172761
Change subject: [BrowserTest] WIP make bullets test modern
......................................................................
[BrowserTest] WIP make bullets test modern
* remove unnecessary wait times
* update for RSpec3.0 syntax
Change-Id: Ie76135154042834e2eb8b008872aced5ac210ee5
---
M modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/61/172761/1
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
index 7c2ee42..a4a50bf 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
@@ -1,6 +1,6 @@
When(/^I click Bullets$/) do
on(VisualEditorPage) do |page|
- page.bullet_number_selector_element.when_present(15).click
+ page.bullet_number_selector_element.when_present.click
page.ve_bullets_element.when_present.click
end
end
@@ -9,21 +9,21 @@
on(VisualEditorPage) do |page|
sleep 2 #this is waiting for the Review Your Changes iframe to disappear
step "I click in the editable part"
- page.bullet_number_selector_element.when_present(15).click
+ page.bullet_number_selector_element.when_present.click
page.decrease_indentation_element.when_present.click
end
end
When(/^I click Increase indentation$/) do
on(VisualEditorPage) do |page|
- page.bullet_number_selector_element.when_present(15).click
+ page.bullet_number_selector_element.when_present.click
page.increase_indentation_element.when_present.click
end
end
When(/^I click Numbering$/) do
on(VisualEditorPage) do |page|
- page.bullet_number_selector_element.when_present(15).click
+ page.bullet_number_selector_element.when_present.click
page.ve_numbering_element.when_present.click
end
end
@@ -32,21 +32,21 @@
on(VisualEditorPage) do |page|
#extra space after 'line' below is a workaround for FF issue where VE is
sending BACKSPACE before RETURN
#probably caused by https://bugzilla.wikimedia.org/show_bug.cgi?id=56274
- page.content_element.when_present(10).send_keys "This is a new line "
- page.content_element.when_present(10).send_keys :return
+ page.content_element.when_present.send_keys "This is a new line "
+ page.content_element.when_present.send_keys :return
end
end
When(/^I undo Bullets$/) do
on(VisualEditorPage) do |page|
- page.bullet_number_selector_element.when_present(15).click
+ page.bullet_number_selector_element.when_present.click
page.ve_bullets_element.when_present.click
end
end
When(/^I undo Numbering$/) do
on(VisualEditorPage) do |page|
- page.bullet_number_selector_element.when_present(15).click
+ page.bullet_number_selector_element.when_present.click
page.ve_numbering_element.when_present.click
end
end
--
To view, visit https://gerrit.wikimedia.org/r/172761
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie76135154042834e2eb8b008872aced5ac210ee5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
