Awight has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/172881

Change subject: ApiCentralNoticeBannerChoiceData tests
......................................................................

ApiCentralNoticeBannerChoiceData tests

Change-Id: I1b1cab6b85ef1386b32d9116844a9f143051f58c
---
M CentralNotice.hooks.php
A tests/ApiCentralNoticeBannerChoiceDataTest.php
2 files changed, 38 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/81/172881/1

diff --git a/CentralNotice.hooks.php b/CentralNotice.hooks.php
index 15ceaf9..6fa682b 100644
--- a/CentralNotice.hooks.php
+++ b/CentralNotice.hooks.php
@@ -364,6 +364,7 @@
 
        $files[ ] = __DIR__ . '/tests/AllocationsTest.php';
        $files[ ] = __DIR__ . '/tests/ApiAllocationsTest.php';
+       $files[ ] = __DIR__ . '/tests/ApiCentralNoticeBannerChoiceDataTest.php';
        $files[ ] = __DIR__ . '/tests/CentralNoticeTest.php';
        $files[ ] = __DIR__ . '/tests/BannerChoiceDataProviderTest.php';
        $files[ ] = __DIR__ . '/tests/BannerTest.php';
diff --git a/tests/ApiCentralNoticeBannerChoiceDataTest.php 
b/tests/ApiCentralNoticeBannerChoiceDataTest.php
new file mode 100644
index 0000000..889017f
--- /dev/null
+++ b/tests/ApiCentralNoticeBannerChoiceDataTest.php
@@ -0,0 +1,37 @@
+<?php
+
+/**
+ * @group CentralNotice
+ * @group medium
+ * @group Database
+ */
+class ApiCentralNoticeBannerChoiceDataTest extends ApiTestCase {
+       /** @var CentralNoticeTestFixtures */
+       protected $cnFixtures;
+
+       protected function setUp() {
+               parent::setUp();
+
+               $this->cnFixtures = new CentralNoticeTestFixtures();
+       }
+
+       protected function tearDown() {
+               $this->cnFixtures->removeFixtures();
+               parent::tearDown();
+       }
+
+       /**
+        * @dataProvider CentralNoticeTestFixtures::allocationsData
+        */
+       public function testBannerChoiceResponse( $fixtures, $expected ) {
+               $this->cnFixtures->addFixtures( $fixtures );
+
+               $ret = $this->doApiRequest( array(
+                       'action' => 'centralnoticebannerchoicedata',
+                       'project' => 'wikipedia',
+                       'language' => 'en',
+                       'status' => 'anonymous',
+               ) );
+               $this->assertTrue( ComparisonUtil::assertSuperset( 
$ret[0]['choices'], $expected ) );
+       }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/172881
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b1cab6b85ef1386b32d9116844a9f143051f58c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to