jenkins-bot has submitted this change and it was merged.
Change subject: Fix possible crash in full-text search.
......................................................................
Fix possible crash in full-text search.
Change-Id: I1c86be495aa7ecfb6640c269016040ca06286364
---
M wikipedia/src/main/java/org/wikipedia/search/FullSearchFragment.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/wikipedia/src/main/java/org/wikipedia/search/FullSearchFragment.java
b/wikipedia/src/main/java/org/wikipedia/search/FullSearchFragment.java
index f08042a..fb0c0a9 100644
--- a/wikipedia/src/main/java/org/wikipedia/search/FullSearchFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/search/FullSearchFragment.java
@@ -243,7 +243,8 @@
private void getWikidataDescriptions(List<FullSearchResult> results) {
List<String> idList = new ArrayList<String>();
for (FullSearchResult r : results) {
- if (app.getWikidataCache().get(r.getWikiBaseId()) == null) {
+ if (!TextUtils.isEmpty(r.getWikiBaseId())
+ && app.getWikidataCache().get(r.getWikiBaseId()) == null) {
// not in our cache yet
idList.add(r.getWikiBaseId());
}
--
To view, visit https://gerrit.wikimedia.org/r/172860
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c86be495aa7ecfb6640c269016040ca06286364
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
