jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: MobileWebCta ......................................................................
Hygiene: MobileWebCta This code isn't loaded anywhere and hasn't been logging events since 31st July 2014 according to the table. Remove https://meta.wikimedia.org/wiki/Schema:MobileWebCta Change-Id: Ib5094a49e8492844742c4017183aa31542879c6d --- M includes/MobileFrontend.hooks.php D javascripts/loggingSchemas/mobileWebCta.js 2 files changed, 0 insertions(+), 45 deletions(-) Approvals: Bmansurov: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/MobileFrontend.hooks.php b/includes/MobileFrontend.hooks.php index 19048cd..b246dca 100644 --- a/includes/MobileFrontend.hooks.php +++ b/includes/MobileFrontend.hooks.php @@ -865,7 +865,6 @@ $mobileEventLoggingSchemas = array( 'MobileWebUploads' => 8209043, 'MobileWebEditing' => 8599025, - 'MobileWebCta' => 5972684, 'MobileWebClickTracking' => 5929948, 'MobileWebWikiGrok' => 10352247, 'MobileWebWikiGrokError' => 10353516, diff --git a/javascripts/loggingSchemas/mobileWebCta.js b/javascripts/loggingSchemas/mobileWebCta.js deleted file mode 100644 index 9abb714..0000000 --- a/javascripts/loggingSchemas/mobileWebCta.js +++ /dev/null @@ -1,44 +0,0 @@ -( function ( M, $ ) { - - function log( status, campaign, step ) { - var - user = M.require( 'user' ), - username = user.getName(), - data = { - status: status, - campaign: campaign || M.query.campaign, - campaignStep: step, - mobileMode: M.getMode() - }; - - if ( username ) { - data.username = username; - data.userEditCount = mw.config.get( 'wgUserEditCount' ); - } - - return M.log( 'MobileWebCta', data ); - } - - // FIXME: Turn into common component shared with MobileWebClickTracking ? - function hijackLink( $el, status, campaign, step, url ) { - function linkHandler( ev ) { - var href; - ev.preventDefault(); - if ( url !== undefined ) { - href = url; - } else { - href = $( this ).attr( 'href' ); - } - log( status, campaign, step ).always( function () { - window.location.href = href; - } ); - } - $el.on( 'click', linkHandler ); - } - - M.define( 'loggingSchemas/mobileWebCta', { - log: log, - hijackLink: hijackLink - } ); - -} )( mw.mobileFrontend, jQuery ); -- To view, visit https://gerrit.wikimedia.org/r/172901 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5094a49e8492844742c4017183aa31542879c6d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <[email protected]> Gerrit-Reviewer: Awjrichards <[email protected]> Gerrit-Reviewer: Bmansurov <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
