Arlolra has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/172943

Change subject: (Bug 50263) Conclude why a.args in sometimes undefined
......................................................................

(Bug 50263) Conclude why a.args in sometimes undefined

 * A few lines above we're pushing an object like { wt: "" } into the
   tplArray.

 * Confirmed this was the case in zhwiki/阿塔瓦爾帕?oldid=26962571 when
   33dd016419f51750c73d1cbabee7dfccc399ba3b landed.

Change-Id: Ic99c338291db4f2728abacce1c62242465f89124
---
M lib/dom.wrapTemplates.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/43/172943/1

diff --git a/lib/dom.wrapTemplates.js b/lib/dom.wrapTemplates.js
index 27d8d53..9ed09cc 100644
--- a/lib/dom.wrapTemplates.js
+++ b/lib/dom.wrapTemplates.js
@@ -700,7 +700,7 @@
                                        // to other transclusions. Should match 
the index of
                                        // the corresponding private metadata 
in paramInfoArrays
                                        // above.
-                                       if (a.args) { // XXX: not sure why args 
can be undefined here
+                                       if (a.args) {
                                                a.args.i = infoIndex;
                                        }
                                        infoIndex++;

-- 
To view, visit https://gerrit.wikimedia.org/r/172943
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic99c338291db4f2728abacce1c62242465f89124
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to