jenkins-bot has submitted this change and it was merged.

Change subject: clean FontAwesome widget (v 1.2.1)
......................................................................


clean FontAwesome widget (v 1.2.1)

*add static function FontAwesomeIcon::getIcons()

Change-Id: I57221f7024d71c538e0f929440f51c60e936561e
---
M PhpTagsWidgets.php
M includes/WidgetFontAwesome.php
M includes/WidgetFontAwesomeIcon.php
3 files changed, 5 insertions(+), 9 deletions(-)

Approvals:
  Pastakhov: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/PhpTagsWidgets.php b/PhpTagsWidgets.php
index 9ddc1d9..7311595 100644
--- a/PhpTagsWidgets.php
+++ b/PhpTagsWidgets.php
@@ -33,7 +33,7 @@
        );
 }
 
-define( 'PHPTAGS_WIDGETS_VERSION' , '1.2.0' );
+define( 'PHPTAGS_WIDGETS_VERSION' , '1.2.1' );
 
 // Register this extension on Special:Version
 $wgExtensionCredits['phptags'][] = array(
diff --git a/includes/WidgetFontAwesome.php b/includes/WidgetFontAwesome.php
index 68cfc39..3550369 100644
--- a/includes/WidgetFontAwesome.php
+++ b/includes/WidgetFontAwesome.php
@@ -9,14 +9,6 @@
  */
 class WidgetFontAwesome extends \PhpTags\GenericWidget {
 
-       private static $icons = array();
-
-       public function m___construct( $value = null, $properties = null ) {
-               $this->addModule( 'ext.PhpTagsWidgets.FontAwesome', true );
-               $this->value[self::DATA] = $value;
-               return parent::m___construct( $properties );
-       }
-
        public static function __callStatic( $name, $arguments ) {
                list ( $callType, $tmp ) = explode( '_', $name, 2 );
 
diff --git a/includes/WidgetFontAwesomeIcon.php 
b/includes/WidgetFontAwesomeIcon.php
index 4d60ed2..5779c09 100644
--- a/includes/WidgetFontAwesomeIcon.php
+++ b/includes/WidgetFontAwesomeIcon.php
@@ -76,6 +76,10 @@
                return parent::checkArguments( $object, $method, $arguments, 
$expects );
        }
 
+       public static function s_getIcons() {
+               return self::$icons;
+       }
+
        private static $icons = array(
                'adjust' => 1,
                'anchor' => 1,

-- 
To view, visit https://gerrit.wikimedia.org/r/172946
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I57221f7024d71c538e0f929440f51c60e936561e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PhpTagsWidgets
Gerrit-Branch: master
Gerrit-Owner: Pastakhov <[email protected]>
Gerrit-Reviewer: Pastakhov <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to