jenkins-bot has submitted this change and it was merged.
Change subject: Move RevisionStore and ValueViewBuilder to repo
......................................................................
Move RevisionStore and ValueViewBuilder to repo
They are only used in repo or jquery.wikibase, which will be moved to repo.
Change-Id: If227e928e9ca8153083d85ada451f30da41fad55
---
M lib/resources/Resources.php
M lib/tests/qunit/resources.php
M repo/resources/Resources.php
R repo/resources/wikibase.RevisionStore.js
R repo/resources/wikibase.ValueViewBuilder.js
M repo/tests/qunit/resources.php
R repo/tests/qunit/wikibase.ValueViewBuilder.tests.js
7 files changed, 29 insertions(+), 29 deletions(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/Resources.php b/lib/resources/Resources.php
index 5287ad1..4198b19 100644
--- a/lib/resources/Resources.php
+++ b/lib/resources/Resources.php
@@ -80,15 +80,6 @@
),
),
- 'wikibase.RevisionStore' => $moduleTemplate + array(
- 'scripts' => array(
- 'wikibase.RevisionStore.js',
- ),
- 'dependencies' => array(
- 'wikibase'
- )
- ),
-
'wikibase.Site' => $moduleTemplate + array(
'scripts' => array(
'wikibase.Site.js',
@@ -108,16 +99,6 @@
'mw.config.values.wbSiteDetails',
'wikibase',
'wikibase.Site',
- ),
- ),
-
- 'wikibase.ValueViewBuilder' => $moduleTemplate + array(
- 'scripts' => array(
- 'wikibase.ValueViewBuilder.js',
- ),
- 'dependencies' => array(
- 'wikibase',
- 'jquery.valueview',
),
),
diff --git a/lib/tests/qunit/resources.php b/lib/tests/qunit/resources.php
index 1d0c361..4bea8bb 100644
--- a/lib/tests/qunit/resources.php
+++ b/lib/tests/qunit/resources.php
@@ -147,16 +147,6 @@
),
),
- 'wikibase.ValueViewBuilder.tests' => $moduleBase + array(
- 'scripts' => array(
- 'wikibase.ValueViewBuilder.tests.js'
- ),
- 'dependencies' => array(
- 'test.sinonjs',
- 'wikibase.ValueViewBuilder'
- )
- ),
-
);
return array_merge(
diff --git a/repo/resources/Resources.php b/repo/resources/Resources.php
index 9f4f707..216926b 100644
--- a/repo/resources/Resources.php
+++ b/repo/resources/Resources.php
@@ -50,11 +50,30 @@
),
),
+ 'wikibase.RevisionStore' => $moduleTemplate + array(
+ 'scripts' => array(
+ 'wikibase.RevisionStore.js',
+ ),
+ 'dependencies' => array(
+ 'wikibase'
+ )
+ ),
+
'wikibase.templates' => $moduleTemplate + array(
'class' => 'Wikibase\TemplateModule',
'scripts' => 'templates.js',
),
+ 'wikibase.ValueViewBuilder' => $moduleTemplate + array(
+ 'scripts' => array(
+ 'wikibase.ValueViewBuilder.js',
+ ),
+ 'dependencies' => array(
+ 'wikibase',
+ 'jquery.valueview',
+ ),
+ ),
+
'wikibase.ui.entityViewInit' => $moduleTemplate + array(
'scripts' => array(
'wikibase.ui.entityViewInit.js' // should
probably be adjusted for more modularity
diff --git a/lib/resources/wikibase.RevisionStore.js
b/repo/resources/wikibase.RevisionStore.js
similarity index 100%
rename from lib/resources/wikibase.RevisionStore.js
rename to repo/resources/wikibase.RevisionStore.js
diff --git a/lib/resources/wikibase.ValueViewBuilder.js
b/repo/resources/wikibase.ValueViewBuilder.js
similarity index 100%
rename from lib/resources/wikibase.ValueViewBuilder.js
rename to repo/resources/wikibase.ValueViewBuilder.js
diff --git a/repo/tests/qunit/resources.php b/repo/tests/qunit/resources.php
index 56b86b4..0d2502d 100644
--- a/repo/tests/qunit/resources.php
+++ b/repo/tests/qunit/resources.php
@@ -36,6 +36,16 @@
),
),
+ 'wikibase.ValueViewBuilder.tests' => $moduleBase + array(
+ 'scripts' => array(
+ 'wikibase.ValueViewBuilder.tests.js'
+ ),
+ 'dependencies' => array(
+ 'test.sinonjs',
+ 'wikibase.ValueViewBuilder'
+ )
+ ),
+
);
return array_merge(
diff --git a/lib/tests/qunit/wikibase.ValueViewBuilder.tests.js
b/repo/tests/qunit/wikibase.ValueViewBuilder.tests.js
similarity index 100%
rename from lib/tests/qunit/wikibase.ValueViewBuilder.tests.js
rename to repo/tests/qunit/wikibase.ValueViewBuilder.tests.js
--
To view, visit https://gerrit.wikimedia.org/r/172956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If227e928e9ca8153083d85ada451f30da41fad55
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
