Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/172983
Change subject: Initialize context's $element as hidden ...................................................................... Initialize context's $element as hidden this.visible is set to false, so the view should be hidden too. This was also causing a scrolling issue on load in Chrome. Bug: 73208 Change-Id: I2662df89618efd2ad1a9032f89af420e73d96fbd --- M src/ui/ve.ui.Context.js 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor refs/changes/83/172983/1 diff --git a/src/ui/ve.ui.Context.js b/src/ui/ve.ui.Context.js index a7e7e38..76a5554 100644 --- a/src/ui/ve.ui.Context.js +++ b/src/ui/ve.ui.Context.js @@ -36,7 +36,9 @@ this.menu.connect( this, { choose: 'onContextItemChoose' } ); // Initialization - this.$element.addClass( 've-ui-context' ); + // Hide element using $.hide() not this.toggle as child implementations + // of toggle may require the instance to be fully constructed before running. + this.$element.addClass( 've-ui-context' ).hide(); this.menu.toggle( false ); this.inspectors.$element.addClass( 've-ui-context-inspectors' ); }; -- To view, visit https://gerrit.wikimedia.org/r/172983 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2662df89618efd2ad1a9032f89af420e73d96fbd Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Esanders <esand...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits