jenkins-bot has submitted this change and it was merged.
Change subject: Trigger claimview "change" event when starting snakview edit
mode
......................................................................
Trigger claimview "change" event when starting snakview edit mode
Bug: 73358
Change-Id: I359683cf3e94437eb601debb8a443a47d072a7b0
---
M lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Adrian Lang: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
index ebcc0f0..1416fba 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
@@ -165,9 +165,15 @@
// set up event listeners:
this.$mainSnak
- .on ( 'snakviewchange', function( event, status ) {
- self._trigger( 'change' );
- } );
+ .on(
+ [
+ 'snakviewchange.' + this.widgetName,
+ 'snakviewafterstartediting.' + this.widgetName
+ ].join( ' ' ),
+ function( event, status ) {
+ self._trigger( 'change' );
+ }
+ );
this.$mainSnak.snakview( {
value: this.mainSnak() || {},
@@ -644,6 +650,7 @@
*/
destroy: function() {
this.$mainSnak.snakview( 'destroy' );
+ this.$mainSnak.off( '.' + this.widgetName );
PARENT.prototype.destroy.call( this );
},
--
To view, visit https://gerrit.wikimedia.org/r/172978
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I359683cf3e94437eb601debb8a443a47d072a7b0
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
