Dbrant has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/173006

Change subject: Clear Wikidata cache when switching languages.
......................................................................

Clear Wikidata cache when switching languages.

Bug: 73349
Change-Id: Id75c15cd2f1a3f36df3b85639a799a6072293f3f
---
M wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
M wikipedia/src/main/java/org/wikipedia/wikidata/WikidataCache.java
2 files changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/06/173006/1

diff --git a/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java 
b/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
index d86f799..8ba18c6 100644
--- a/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
@@ -211,6 +211,9 @@
                         Log.d("Wikipedia", "Show da main page yo");
                     }
                 }, DateUtils.SECOND_IN_MILLIS);
+                // clear Wikidata cache, since the descriptions will need to be
+                // re-fetched in the new language.
+                app.getWikidataCache().clear();
             } else if (resultCode == SettingsActivity.ACTIVITY_RESULT_LOGOUT) {
                 doLogout();
             }
diff --git a/wikipedia/src/main/java/org/wikipedia/wikidata/WikidataCache.java 
b/wikipedia/src/main/java/org/wikipedia/wikidata/WikidataCache.java
index 976c7e3..853f650 100644
--- a/wikipedia/src/main/java/org/wikipedia/wikidata/WikidataCache.java
+++ b/wikipedia/src/main/java/org/wikipedia/wikidata/WikidataCache.java
@@ -19,6 +19,10 @@
         this.app = app;
     }
 
+    public void clear() {
+        descriptionCache.evictAll();
+    }
+
     public void put(String key, String value) {
         descriptionCache.put(key, value);
     }

-- 
To view, visit https://gerrit.wikimedia.org/r/173006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id75c15cd2f1a3f36df3b85639a799a6072293f3f
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to