MarkTraceur has uploaded a new change for review. https://gerrit.wikimedia.org/r/173054
Change subject: Toggle the panel when "view more" is clicked ...................................................................... Toggle the panel when "view more" is clicked Better for reading the license information. Change-Id: I9299d62baafdcc797e66fe3c17fe9c3712570105 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/988 --- M resources/mmv/ui/mmv.ui.metadataPanel.js M resources/mmv/ui/mmv.ui.permission.js 2 files changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/54/173054/1 diff --git a/resources/mmv/ui/mmv.ui.metadataPanel.js b/resources/mmv/ui/mmv.ui.metadataPanel.js index 08bee32..82c5ab3 100644 --- a/resources/mmv/ui/mmv.ui.metadataPanel.js +++ b/resources/mmv/ui/mmv.ui.metadataPanel.js @@ -196,7 +196,7 @@ this.initializeCredit(); this.description = new mw.mmv.ui.Description( this.$imageMetadataLeft ); - this.permission = new mw.mmv.ui.Permission( this.$imageMetadataLeft ); + this.permission = new mw.mmv.ui.Permission( this.$imageMetadataLeft, this.scroller ); this.initializeImageLinks(); }; @@ -284,7 +284,7 @@ .hide() .on( 'click', function() { panel.permission.grow(); - panel.scroller.toggle(); + panel.scroller.toggle( 'up' ); return false; } ); }; diff --git a/resources/mmv/ui/mmv.ui.permission.js b/resources/mmv/ui/mmv.ui.permission.js index 4e103a8..74919af 100644 --- a/resources/mmv/ui/mmv.ui.permission.js +++ b/resources/mmv/ui/mmv.ui.permission.js @@ -27,8 +27,9 @@ * @extends mw.mmv.ui.Element * @constructor * @param {jQuery} $container + * @param {mw.mmv.ui.MetadataPanelScroller} scroller */ - function Permission( $container ) { + function Permission( $container, scroller ) { var permission = this; mw.mmv.ui.Element.call( this, $container ); @@ -64,6 +65,7 @@ .on( 'click', '.mw-mmv-permission-text-viewmore', function( e ) { e.preventDefault(); permission.grow(); + permission.scroller.toggle( 'up' ); } ) ; @@ -99,6 +101,12 @@ permission.shrink(); } ) .appendTo( this.$box ); + + /** + * Panel scroller from the metadata panel object. + * @property {mw.mmv.ui.MetadataPanelScroller} + */ + this.scroller = scroller; } oo.inheritClass( Permission, mw.mmv.ui.Element ); P = Permission.prototype; -- To view, visit https://gerrit.wikimedia.org/r/173054 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9299d62baafdcc797e66fe3c17fe9c3712570105 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: MarkTraceur <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
