Hello Ottomata,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/173065
to review the following change.
Change subject: Turn EventLogging's logrotate config into template
......................................................................
Turn EventLogging's logrotate config into template
EventLogging's logrotate config uses variables since
eed057682ed856a4489f95d274c072e58fe64ff0
but is still included as file, so the variables are not rendered with
their values. Hence, we turn the file into a template.
Change-Id: Iad0d9982cee45a9ae1f423d7100eaccca6d7a20e
---
M modules/eventlogging/manifests/init.pp
R modules/eventlogging/templates/logrotate.erb
2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/65/173065/1
diff --git a/modules/eventlogging/manifests/init.pp
b/modules/eventlogging/manifests/init.pp
index a4c3234..8404981 100644
--- a/modules/eventlogging/manifests/init.pp
+++ b/modules/eventlogging/manifests/init.pp
@@ -113,7 +113,7 @@
}
file { '/etc/logrotate.d/eventlogging':
- source => 'puppet:///modules/eventlogging/logrotate',
+ content => template('eventlogging/logrotate.erb'),
require => File["${log_dir}/archive"],
mode => '0444',
}
diff --git a/modules/eventlogging/files/logrotate
b/modules/eventlogging/templates/logrotate.erb
similarity index 100%
rename from modules/eventlogging/files/logrotate
rename to modules/eventlogging/templates/logrotate.erb
--
To view, visit https://gerrit.wikimedia.org/r/173065
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad0d9982cee45a9ae1f423d7100eaccca6d7a20e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
