jenkins-bot has submitted this change and it was merged.
Change subject: Click track clicks to references
......................................................................
Click track clicks to references
Change-Id: Ifd9d88138ce203df4b914ae2d01c5d3c8bfb49ff
---
M includes/Resources.php
M javascripts/modules/references/init.js
2 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Resources.php b/includes/Resources.php
index 02d21bd..8856e9f 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -712,6 +712,7 @@
'mobile.references' => $wgMFResourceFileModuleBoilerplate + array(
'dependencies' => array(
'mobile.drawers',
+ 'mobile.loggingSchemas',
),
'styles' => array(
'less/modules/references.less',
diff --git a/javascripts/modules/references/init.js
b/javascripts/modules/references/init.js
index 958704f..ace2520 100644
--- a/javascripts/modules/references/init.js
+++ b/javascripts/modules/references/init.js
@@ -1,5 +1,6 @@
( function ( M, $ ) {
- var drawer;
+ var drawer,
+ MobileWebClickTracking = M.require(
'loggingSchemas/MobileWebClickTracking' );
function getReference( id ) {
// Escape (almost) all CSS selector meta characters
@@ -11,10 +12,13 @@
}
function showReference( ev ) {
- var $dest = $( this );
+ var $dest = $( this ),
+ href = $dest.attr( 'href' );
+
+ MobileWebClickTracking.log( 'reference', href );
drawer.render( {
title: $dest.text(),
- text: getReference( $dest.attr( 'href' ) ).html()
+ text: getReference( href ).html()
} );
ev.preventDefault();
//don't hide drawer (stop propagation of click) if it is
already shown (e.g. click another reference)
--
To view, visit https://gerrit.wikimedia.org/r/173079
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd9d88138ce203df4b914ae2d01c5d3c8bfb49ff
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
